Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chooseImage 支持 sizeType 参数 #159

Closed
wants to merge 1 commit into from
Closed

fix: chooseImage 支持 sizeType 参数 #159

wants to merge 1 commit into from

Conversation

iChengbo
Copy link
Collaborator

@iChengbo iChengbo commented Jul 15, 2021 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)

1、Taro.chooseImage 支持 sizeType 属性，issue（android 端不支持压缩）；

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

zhiqingchen
zhiqingchen reviewed Jul 15, 2021
View reviewed changes
packages/taro-rn/src/lib/chooseImage/index.ts
SYImagePicker.showImagePicker({
imageCount,
quality: sizeType[0] === 'compressed' ? 70 : 90,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里70与90的依据是？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.9 是原始图大小，1 的话得到的图会比原始图大，0.7是微聊客开发中的经验值，不影响失真

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqingchen zhiqingchen zhiqingchen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iChengbo @zhiqingchen